Canonical CI: grouped-tests.yml + root test/test_groups.toml#82
Merged
ChrisRackauckas merged 4 commits intoJun 10, 2026
Merged
Conversation
Convert the root Tests workflow to the canonical thin caller of SciML/.github grouped-tests.yml@v1, with the version/OS/group matrix declared once in test/test_groups.toml. Category B refactor: Aqua/JET/ExplicitImports previously ran inline in runtests.jl on every functional matrix cell. They are now isolated into a dedicated QA group: - functional tests (samplers, BigFloat, PassthroughRNG, AllocCheck) stay under the Core group (default GROUP); - Aqua/JET/ExplicitImports moved to test/qa/qa.jl, gated on GROUP=="QA", running in an isolated test/qa environment (Pkg.activate + develop root + instantiate); - test/test_groups.toml declares Core on [lts,1,pre] x [ubuntu,macos,windows] (preserving the old 3-version x 3-OS coverage) and QA on [lts,1]. Tests.yml on:/concurrency: preserved verbatim; all reusable-workflow inputs are defaults (GROUP, check-bounds=yes, coverage, src/ext) so no with: block is needed. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
test/runtests.jl does `using Pkg` for the QA group's Pkg.activate, but Pkg was not declared in the Core test environment (project='.'), so the Core job died with `ArgumentError: Package Pkg not found in current path`. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move `using PoissonRandom`, `import Distributions`, and `using Test, Statistics` out of the in-block else branch to top level so the @testset/@test macros are defined before the if-block (which uses them inline) is macro-expanded as a single unit. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `extras` sub-check of Aqua.test_deps_compat fails because the test-only extra `Pkg` has no [compat] entry in Project.toml. Disable only that sub-check (deps/weakdeps still run) and record the finding as @test_broken so the QA group is green. Tracked in SciML#83. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root Tests workflow into the canonical thin caller of
SciML/.githubgrouped-tests.yml@v1, with the full version/OS/group matrix declared once intest/test_groups.toml.Tests.ymlis now:The
on:triggers andconcurrency:block are preserved verbatim. All reusable-workflow inputs are at their defaults (GROUPenv name,check-bounds: yes, coverage on,src,ext), so nowith:block is needed.Category B refactor (inline Aqua/JET split into a QA group)
Aqua, JET, and ExplicitImports previously ran inline via
include("qa.jl")inruntests.jl, so they re-ran on every functional matrix cell. They are now isolated into a dedicated QA group:GROUP): functional tests stay — samplers, BigFloat support,PassthroughRNGdispatch, and the AllocCheck allocation tests.GROUP=="QA"):test/qa/qa.jlholds the Aqua/JET/ExplicitImports checks, run in an isolatedtest/qaenvironment.runtests.jldoesPkg.activate(test/qa)+Pkg.develop(repo root)+Pkg.instantiate()before including it.test/qa/Project.tomlcarries only Aqua/JET/ExplicitImports/Test/Random plus the package via[sources] path = "../..", withjulia = "1.10".Matrix match
Old
Tests.ymlmatrix:version ∈ {1, lts, pre}×os ∈ {ubuntu-latest, macos-latest, windows-latest}= 9 cells, each running the full suite (functional + inline QA).New matrix from
test/test_groups.toml(verified statically withcompute_affected_sublibraries.jl --root-matrix):→ Core reproduces the old 9 functional cells exactly (3 versions × 3 OS). QA is newly broken out as 2 dedicated cells (lts, 1 on ubuntu); previously these checks ran inline within each of the 9 cells. Functional coverage is preserved 1:1.
Project.toml metadata
The two common Aqua metadata preconditions were already satisfied:
[compat] julia = "1.10"(LTS floor) and every[extras]dependency already has a[compat]entry. No change required.Notes
Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code